Radium to emotion #379
Merged
Radium to emotion #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the reasoning behind switching from radium to emotion? |
|
@ebertmi This is the first phase in rewriting the themeing story and also a general refactor. We want to move to a modern css-in-js styling solution. Then look at where things are in how to make theming more approachable. |
kenwheeler
reviewed
Oct 26, 2017
| styles.user | ||
| ]); | ||
|
|
||
| const UnfitText = styled.p(({ lineHeight, styles }) => [ |
|
OK hold up, got some prollems. I'll send you videos |
carloskelly13
force-pushed
the
radium-to-emotion
branch
from
188e911 to
053abe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Radiumdecorators for components toreact-emotioncomponentsSlidetransitions and simplify logic