Skip to content

fix appears #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: ALT-O Keyboard shortcut fix. Issue: #888
merged 4 commits into from
Oct 20, 2017
Merged

fix appears #376

merged 4 commits into from
Oct 20, 2017

Conversation

@kenwheeler
Copy link
Contributor

No description provided.

ryan-roemer
ryan-roemer approved these changes Oct 19, 2017
View reviewed changes
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but there are lint failures for setState which need to get fixed. I'd jump in, but it may require a substantive change.

@kenwheeler kenwheeler merged commit c5fbf29 into master Oct 20, 2017
@kale-stew kale-stew deleted the fix-appears branch October 31, 2019 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryan-roemer ryan-roemer ryan-roemer approved these changes

Assignees

@ryan-roemer ryan-roemer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenwheeler @ryan-roemer