Skip to content

Fix React warnings for uppercase HTML heading elements #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Fix React warnings for uppercase HTML heading elements #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cd4989
Minor README spacing fix
Conrad2134 Oct 16, 2017
d4b026e
Prevent console spam on uppercase heading element
Conrad2134 Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export default class extends Component {

Here is where you can use the library's tags to compose your presentation. While you can use any JSX syntax here, building your presentation with the supplied tags allows for theming to work properly.

The bare minimum you need to start is a`Deck` element and a `Slide` element. Each `Slide` element represents a slide inside of your slideshow.
The bare minimum you need to start is a `Deck` element and a `Slide` element. Each `Slide` element represents a slide inside of your slideshow.

<a name="themes"></a>
### Themes
Expand Down
4 changes: 2 additions & 2 deletions src/components/__snapshots__/heading.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`<Heading /> should render correctly. 1`] = `
lineHeight={1}
size={2}
>
<H2
<h2
className={undefined}
data-radium={true}
style={
Expand All @@ -16,7 +16,7 @@ exports[`<Heading /> should render correctly. 1`] = `
}
>
Hi There!
</H2>
</h2>
</Heading>
`;

Expand Down
2 changes: 1 addition & 1 deletion src/components/heading.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export default class Heading extends Component {
}
render() {
const { size, lineHeight, fit, style, children } = this.props;
const Tag = `H${size}`;
const Tag = `h${size}`;
const styles = {
container: {
display: 'block',
Expand Down