Update create-spectacle to use import map and ESM-based one page template.
#1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carloskelly13
changed the title
spectacle-cli to use import map and ESM-based one page template.create-spectacle to use import map and ESM-based one page template.
scottrippey
reviewed
Nov 20, 2023
scottrippey
approved these changes
Nov 20, 2023
scottrippey
approved these changes
Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
one-pageoutput used an outdated version of Spectacle and hard-coded in the dependencies. This implements our dynamic generation for theone-page.htmloption from thecreate-spectacleCLI and moves it over to use ESM and import maps.How to test →
packages/create-spectaclepnpm run devone-pagedeck