Skip to content

Fix deck state transitions. Add test cases for deck state reducer. #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2023
Merged

Fix deck state transitions. Add test cases for deck state reducer. #1290

merged 5 commits into from
Jul 24, 2023

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented Jul 22, 2023 •
edited
Loading

Description

  • Fixes transition animations not happening when a deck is controlled by a presenter mode view
  • Adds test coverage for deck state reducer and util functions
Fixed.Transitions.mov

Fixes #1287

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Run pnpm run start:ts and have a presenter mode (Cmd + K) and regular window open and verify transitions happen in the regular view.

@vercel
Copy link

vercel bot commented Jul 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2023 1:11am

@carloskelly13 carloskelly13 marked this pull request as ready for review July 23, 2023 14:02
@carloskelly13 carloskelly13 requested a review from gksander July 24, 2023 12:11
gksander
gksander approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. love these test cases!

@carloskelly13 carloskelly13 merged commit caa013f into main Jul 24, 2023
@carloskelly13 carloskelly13 deleted the fix/deck-state-transitions branch July 24, 2023 13:45
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gksander gksander gksander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: using presenterMode causes slide transition animations not to function on display screen when steps are used

2 participants

@carloskelly13 @gksander