-
Couldn't load subscription status.
- Fork 699
"UMD" build with tsup #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
"UMD" build with tsup #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kicked the tires locally and dropped it into some one-page decks and things just worked. My only thought is if we want to produce a minified build as well. |
carloskelly13
approved these changes
May 9, 2023
gksander
commented
May 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drops webpack for tsup for the browser/umd build which simplifies the build steps quite a bit. Note: umd file will now be imported from a different location (
lib/index.global.jsinstead ofdist/spectacle.min.js). We can tweak that name, I believe, if we need to.Fixes # (issue)
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
pnpm run check:ciand all checks pass