Skip to content

Conversation

@gksander
Copy link
Contributor

@gksander gksander commented May 9, 2023

Description

Drops webpack for tsup for the browser/umd build which simplifies the build steps quite a bit. Note: umd file will now be imported from a different location (lib/index.global.js instead of dist/spectacle.min.js). We can tweak that name, I believe, if we need to.

Fixes # (issue)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run pnpm run check:ci and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 4:55pm

@carloskelly13
Copy link
Contributor

Kicked the tires locally and dropped it into some one-page decks and things just worked. My only thought is if we want to produce a minified build as well.

@gksander gksander merged commit bfe221d into main May 9, 2023
@gksander gksander deleted the one-page branch May 9, 2023 16:56
@github-actions github-actions bot mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants