Skip to content

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented May 9, 2023

Description

Currently we make folks jump through installing react-syntax-highlighter to use different themes. This just re-exports all the themes and merges in our current default vsCodeDark theme.

The size of Spectacle (esm) increases to 124.26 KB from 124.09 KB.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added an example to the TypeScript-demo app.

@carloskelly13 carloskelly13 requested a review from gksander May 9, 2023 00:09
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview May 9, 2023 0:09am

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carloskelly13 carloskelly13 merged commit 1915b6c into main May 9, 2023
@carloskelly13 carloskelly13 deleted the feat/export-codepane-themes branch May 9, 2023 12:38
@github-actions github-actions bot mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants