-
Couldn't load subscription status.
- Fork 699
Added support for App Router + SSR, moved to tsup for ESM/CJS
#1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tsup for buildingtsup for ESM/CJS
ab1edfe to
20a820e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Mostly minor cleanup, one Node SSR thing that should be straightforward.
Also, presently I'm getting a git diff after install of pnpm-lock.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Mostly minor cleanup, one Node SSR thing that should be straightforward.
Also, presently I'm getting a git diff after install of pnpm-lock.yaml
e918cc1 to
25f9150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
3ab6b8b to
cf7ba91
Compare
cf7ba91 to
25f9150
Compare
Description
tsupto build the CJS and ESM outputs, keepwebpackfor UMD, which is required byone-page.<DefaultTemplate />component which is often recreated each time a person makes a deck 👇🏻Updated Docs
Tutorial → https://spectacle-docs-website-hsg05kt4y-formidable-labs.vercel.app/docs/tutorial
Templates → https://spectacle-docs-website-hsg05kt4y-formidable-labs.vercel.app/docs/api-reference#templates-
Addresses #1260
Type of Change
How Has This Been Tested?
yarn/npmlinking the library.Note If you are testing one page you will need to build the library and uncomment out the local spectacle dist file as it will be expecting the new
DefaultTemplateexport.