Skip to content

Conversation

@carloskelly13
Copy link
Contributor

@carloskelly13 carloskelly13 commented May 6, 2023

Description

  • Removes reference to create react app in favor of Vite + NextJS
  • We move to tsup to build the CJS and ESM outputs, keep webpack for UMD, which is required by one-page.
  • Fixes Spectacle support to work in SSR environments including NextJS App Router
  • Adds the <DefaultTemplate /> component which is often recreated each time a person makes a deck 👇🏻

default-template

Updated Docs

Tutorialhttps://spectacle-docs-website-hsg05kt4y-formidable-labs.vercel.app/docs/tutorial
Templateshttps://spectacle-docs-website-hsg05kt4y-formidable-labs.vercel.app/docs/api-reference#templates-

Addresses #1260

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Running the examples including one-page after building the library
  2. Following the examples in the documentation and yarn/npm linking the library.

Note If you are testing one page you will need to build the library and uncomment out the local spectacle dist file as it will be expecting the new DefaultTemplate export.

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 4:41pm

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Mostly minor cleanup, one Node SSR thing that should be straightforward.

Also, presently I'm getting a git diff after install of pnpm-lock.yaml

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Mostly minor cleanup, one Node SSR thing that should be straightforward.

Also, presently I'm getting a git diff after install of pnpm-lock.yaml

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants