Skip to content

Bug: Lib babel output is CommonJS #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2023
Merged

Bug: Lib babel output is CommonJS #1251

merged 2 commits into from
Jan 3, 2023

Conversation

@ryan-roemer
Copy link
Member

Fixes #1250

@ryan-roemer ryan-roemer mentioned this pull request Jan 3, 2023
Closed
carloskelly13
carloskelly13 approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ryan-roemer ryan-roemer merged commit f3b8dda into main Jan 3, 2023
@ryan-roemer ryan-roemer deleted the bug/spectacle-cjs branch January 3, 2023 20:25
This was referenced Jan 3, 2023
Closed
Open
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@carloskelly13 carloskelly13 carloskelly13 approved these changes

@gksander gksander gksander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: lib (CJS) is outputting ESM

3 participants

@ryan-roemer @carloskelly13 @gksander