Fix: theme.backdropStyle overrides #1231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently no straightforward way to override the background color of the presentation backdrop.
theme.backdropStylefrom being overridden by the default black color.backdropStyle, is accessible from theDeckprops, but not present in the TypeScript types, so TypeScript users had to use a workaround to push it through.My judgement was that there was no need to have multiple ways to accomplish the same outcome with the styling props, as it complicates the implementation and the API. I ultimately kept the current behavior the same, except for the bug that causes
theme.backdropStyle.background[Color]to be ignored, but marked the excess props (backdropStyle,suppressBackdropFallback,theme.suppressBackdropFallback) as deprecated in the TypeScript types, to be removed in the next major release.Fixes #1051
Type of Change
How Has This Been Tested?
New unit tests