Skip to content

Conversation

@ZimChristine
Copy link
Contributor

@ZimChristine ZimChristine commented Sep 13, 2022

Description

The changes in this PR add four new Slide Layouts for Images.
-Horizontal Image slide with optional Title and Description
-Vertical Image slide with List pane and optional Title
-Three Up Image slide
-Full Bleed Image slide

Known issue

This PR perpetuates a ts-ignore that ought to be fixed in a subsequent PR:
https://github.com/FormidableLabs/spectacle/pull/1221/files#diff-c1ac090b2ff636b65120246c862260a07e29ceacc75778bc3c88ec0d89868a9bR108
https://github.com/FormidableLabs/spectacle/pull/1221/files#diff-c1ac090b2ff636b65120246c862260a07e29ceacc75778bc3c88ec0d89868a9bR438

Type of Change

  • [ x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Jest tests have been added. All Image layouts were tested in the example apps.

Checklist: (Feel free to delete this section upon completion)

  • [ x ] I have included a changeset if this change will require a version change to one of the packages.
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have run pnpm run check:ci and all checks pass
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] My changes generate no new warnings
  • [ na ] Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot temporarily deployed to staging-1221 September 15, 2022 22:29 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 15, 2022 22:30 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 21, 2022 17:36 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 21, 2022 18:32 Inactive
@ZimChristine ZimChristine marked this pull request as ready for review September 21, 2022 18:32
@github-actions github-actions bot temporarily deployed to staging-1221 September 21, 2022 18:32 Inactive
@gksander gksander requested a review from fritz-c September 26, 2022 13:28
@github-actions github-actions bot temporarily deployed to staging-1221 September 27, 2022 17:38 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 27, 2022 17:39 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 27, 2022 17:52 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 27, 2022 17:52 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 27, 2022 18:01 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 27, 2022 18:01 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 30, 2022 18:52 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 30, 2022 19:52 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 30, 2022 19:56 Inactive
@ZimChristine
Copy link
Contributor Author

ZimChristine commented Sep 30, 2022

When all checks pass, would like to merge this without-objection. cc @gksander @fritz-c.

Edit: Tables got messed up during resolving a conflict so fixing that first.

@github-actions github-actions bot temporarily deployed to staging-1221 September 30, 2022 19:59 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 30, 2022 20:00 Inactive
@github-actions github-actions bot temporarily deployed to staging-1221 September 30, 2022 20:08 Inactive
@ZimChristine ZimChristine merged commit 2fd15b3 into main Sep 30, 2022
@ZimChristine ZimChristine deleted the img-layout branch September 30, 2022 20:16
@github-actions github-actions bot mentioned this pull request Sep 30, 2022
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants