-
Couldn't load subscription status.
- Fork 699
feat: Add Image options to Slide Layouts. #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritz-c
suggested changes
Sep 26, 2022
fritz-c
approved these changes
Sep 30, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in this PR add four new Slide Layouts for Images.
-Horizontal Image slide with optional Title and Description
-Vertical Image slide with List pane and optional Title
-Three Up Image slide
-Full Bleed Image slide
Known issue
This PR perpetuates a ts-ignore that ought to be fixed in a subsequent PR:
https://github.com/FormidableLabs/spectacle/pull/1221/files#diff-c1ac090b2ff636b65120246c862260a07e29ceacc75778bc3c88ec0d89868a9bR108
https://github.com/FormidableLabs/spectacle/pull/1221/files#diff-c1ac090b2ff636b65120246c862260a07e29ceacc75778bc3c88ec0d89868a9bR438
Type of Change
How Has This Been Tested?
Jest tests have been added. All Image layouts were tested in the example apps.
Checklist: (Feel free to delete this section upon completion)
pnpm run check:ciand all checks pass