Skip to content

Slide layout tweaks #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2022
Merged

Slide layout tweaks #1213

merged 2 commits into from
Aug 24, 2022

Conversation

@gksander
Copy link
Contributor

This PR builds off of #1209, tweaks just a couple of very minor things:

  • For SlideLayout.BigFact, use children for the fact prop (instead of a separate prop).
  • For SlideLayout.Quote, use children for the quote prop (instead of a separate prop).
  • Updates docs accordingly.

carloskelly13
carloskelly13 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the migration to using children. I'm not a huge fan of elements with a single render prop.

@gksander gksander merged commit 7411cde into main Aug 24, 2022
@gksander gksander deleted the slide-layout-tweaks branch August 24, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZimChristine ZimChristine Awaiting requested review from ZimChristine

1 more reviewer

@carloskelly13 carloskelly13 carloskelly13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gksander @carloskelly13