create-spectacle: Better check for overwrite
#1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gksander
commented
Aug 15, 2022
|
@carlos-kelly just a friendly little ping. I think after this, most of the foundational work is in place for |
carloskelly13
approved these changes
Aug 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1199
Since
onepagegenerates a single HTML file, but other deck types create a directory – we need to have a bit of a logic fork for determining whether or not we'll be overwriting (and when to prompt the user to confirm an overwrite). The approach here is to just move thetypeprompt right aftername(but before the overwrite confirmation), so we can appropriately determine when we need to overwrite (based on bothtypeandname).