Skip to content

Conversation

@gksander
Copy link
Contributor

@gksander gksander commented Aug 10, 2022

What's the issue?

Running yarn create spectacle results in this error:

Error: Cannot find module 'spectacle/package.json'
Require stack:
- /Users/gksander/.config/yarn/global/node_modules/create-spectacle/bin/cli.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)

This is due to us trying to import package.json from spectacle, which is not installed.

gksander and others added 2 commits August 10, 2022 12:05
Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
@gksander gksander closed this Aug 10, 2022
@gksander gksander reopened this Aug 10, 2022
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I think this all should work (e.g. that changesets will correctly replace workspace:* with version on release)

I'm not totally sure, however, if we want to do linked for spectacle and create-spectacle per https://github.com/changesets/changesets/blob/main/docs/linked-packages.md

@gksander gksander merged commit 25e4698 into main Aug 10, 2022
@gksander gksander deleted the create-spectacle-version-fix branch August 10, 2022 18:47
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants