Skip to content
This repository was archived by the owner on Dec 15, 2018. It is now read-only.

Conversation

kale-stew
Copy link

All immutable imports now must be separately imported. For example:

import { immutableRouterForBrowser, ImmutableLink } from 'redux-little-router/es/immutable';
import { combineReducers } from 'redux-immutable';

Checklist:

  • Move immutable/* re-exports to immutable/index.js
  • Scour and update docs
  • Scour and update examples

@kale-stew kale-stew requested a review from ryan-roemer February 5, 2018 18:58
@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          28       28           
  Lines         362      362           
=======================================
  Hits          357      357           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b37e3...25da7a9. Read the comment docs.

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get @tptee to review and double check there aren't any gotcha's I'm missing...

@ryan-roemer
Copy link
Member

@stefvhuynh -- Mind taking a look at this too since we're moving around your immutable work?

Copy link
Contributor

@tptee tptee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryan-roemer ryan-roemer merged commit 2765bef into master Feb 5, 2018
@ryan-roemer ryan-roemer deleted the task/immutable branch February 5, 2018 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants