This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Include POP action type as a public action type #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR which adds the
POP(ROUTER_POP) action type to the public exports insrc/index.js. Of all the types defined insrc/types.js, this is the only one that was not included in the list of "public action types".From what I can tell, it's quite useful since it's the only action which fires for both router induced back behavior (e.g.,
goBack()) and for browser induced back button (e.g., the browser's back button).