This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Upgrades the peer dependency for react-redux to 5.0 (optionally 4) #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though react-redux's [5.0.0 release is backwards compatible with 4.0.0])(https://github.com/reactjs/react-redux/releases/tag/v5.0.0), in the spirit of supporting multiple versions as with the react and react-dom dependency, this change allows either version to be used. This will silence the peer dependency warning.
Current coverage is 98.26% (diff: 100%)@@ master #134 diff @@
==========================================
Files 19 19
Lines 231 231
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 227 227
Misses 4 4
Partials 0 0
|
tptee
approved these changes
Jan 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been seeing a peer dependency warning re. react-redux, and this PR bumps the version but maintains the older version (as established with the other peer dependencies). After a period of time—once it's fairly certain that 5.0 is in actuality a non-breaking release—the 4.0 option could be removed.
From the commit:
Though react-redux's [5.0.0 release is backwards compatible with 4.0.0])(https://github.com/reactjs/react-redux/releases/tag/v5.0.0), in the spirit of supporting multiple versions as with the react and react-dom dependency, this change allows either version to be used.
This will silence the peer dependency warning.