Skip to content
This repository was archived by the owner on Dec 15, 2018. It is now read-only.
This repository was archived by the owner on Dec 15, 2018. It is now read-only.

A few documentation issues #35

Closed
Closed
@dpwrussell

Description

@dpwrussell

First let me just say that having used React + Reach Router + React Router Redux for some time I am extremely happy that there is work in progress on an alternative as I basically agree with nearly everything in the trilogy of blog posts. When I learnt React I was convinced that it was the future, and again with Redux... then as soon as I started adding the Router I felt like I'd lost a lot of the things I'd liked in the first place.

I think there is a mistake when saying:

Like React Router's <Provider>, you'll want to wrap provideRouter around your app's top-level component like so. (fixed in #37)

I think this should probably say Router not Provider as that is the part of React Router that this seems to resemble. Provider is from react-redux and is definitely still needed, which I think also needs reinforcing.

Keep up the good work, I will be testing this as it develops, happy to help in any way I can, and look forward to reaching the point when it can be used in production.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions