Skip to content

iOS setup instructions conflict with reactnavigation #616

Closed
@badsyntax

Description

Issue

Hello. It would be great if the README provided some additional info to explain how to combine the auth redirect logic with existing deeplinking libraries.

The instructions for react-native-app-auth:

+ - (BOOL)application:(UIApplication *)app openURL:(NSURL *)url options:(NSDictionary<NSString *, id> *) options {
+  return [self.authorizationFlowManagerDelegate resumeExternalUserAgentFlowWithURL:url];
+ }

The instructions for reactnavigation:

+ - (BOOL)application:(UIApplication *)application
+    openURL:(NSURL *)url
+    options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options
+ {
+  return [RCTLinkingManager application:application openURL:url options:options];
+ }

It would be great if the README provided some guidance on how to combine the two. Something on the lines of:

- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
            options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options {
  if (SOME_CONDITION){
    return [self.authorizationFlowManagerDelegate resumeExternalUserAgentFlowWithURL:url];
  } else{
    return [RCTLinkingManager application:application openURL:url options:options];
  }
}

I just don't what what SOME_CONDITION should be, to let the authorizationFlowManagerDelegate handle the redirect url. It would be awesome to provide an example in the README.


Environment

  • Your Identity Provider: Azure B2C
  • Platform that you're experiencing the issue on: iOS
  • Are you using Expo? No

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions