Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update useKeyboard hook to use default argument for shouldHandleKeyboardEvents #265

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

JDMathew
Copy link
Collaborator

Description

Updates useKeyboard hook argument shouldHandleKeyboardEvents to default to true thus making it not a required arg for the hook

Documentation update for this PR included in #257

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JDMathew JDMathew requested a review from ceceppa October 11, 2024 07:17
@JDMathew JDMathew self-assigned this Oct 11, 2024
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 7:17am

@JDMathew JDMathew merged commit ed9b693 into main Oct 12, 2024
3 checks passed
@JDMathew JDMathew deleted the feat/useKeyboard-default-arguments branch October 12, 2024 01:08
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant