Updating Lists to us RN over native module ListWrapper (#269)

* remove ListWrapper from components * Remove ListWrapper comp * Remove ListWrapper doc * remove export of ListWrapper * remove ref to ListWrapper * Added changesets
FormidableLabs · Nov 18, 2024 · 71cb312 · 71cb312
1 parent e5b1c06
commit 71cb312
Show file tree

Hide file tree

Showing 11 changed files with 19 additions and 169 deletions.
diff --git a/.changeset/kind-impalas-carry.md b/.changeset/kind-impalas-carry.md
@@ -0,0 +1,11 @@
+---
+'@react-native-ama/lists': minor
+'@react-native-ama/animations': minor
+'@react-native-ama/core': minor
+'@react-native-ama/extras': minor
+'@react-native-ama/forms': minor
+'@react-native-ama/internal': minor
+'@react-native-ama/react-native': minor
+---
+
+Removed ListWrapper and corresponding native module allowing `lists` package to be used in expo apps
diff --git a/packages/lists/docs/DynamicFlatList.mdx b/packages/lists/docs/DynamicFlatList.mdx
@@ -19,18 +19,6 @@ import { DynamicFlatList } from '@react-native-ama/lists';
 />
 ```
 
-## Accessibility Improvements
-
-- On `Android` allows TalkBack to announce **in list**/**out list** or **in grid**/**out of grid**
-- A [dynamic list](./DynamicFlatList.mdx) automatically announces the number of items found when
-it gets filtered
-
-### TalkBack
-
-<TalkBackList />
-
-To provide this accessibility feature AMA wraps the list in the custom native
-component: [ListWrapper](./ListWrapper.mdx).
 
 ### Dynamic list
 

diff --git a/packages/lists/docs/FlatList.mdx b/packages/lists/docs/FlatList.mdx
@@ -19,16 +19,6 @@ import { FlatList } from '@react-native-ama/lists';
 />
 ```
 
-## Accessibility Improvements
-
-- On `Android` allows TalkBack to announce **in list**/**out list** or **in grid**/**out of grid**
-- A [dynamic list](./DynamicFlatList.mdx) automatically announces the number of items found when it gets filtered
-
-### TalkBack
-
-<TalkBackList />
-
-To provide this accessibility feature AMA wraps the list in the custom native component: [ListWrapper](./ListWrapper.mdx).
 
 ### Dynamic list
 

diff --git a/packages/lists/docs/ListWrapper.mdx b/packages/lists/docs/ListWrapper.mdx
diff --git a/packages/lists/docs/StaticFlatList.mdx b/packages/lists/docs/StaticFlatList.mdx
@@ -16,17 +16,6 @@ import { StaticFlatList } from '@react-native-ama/lists';
 />
 ```
 
-## Accessibility Improvements
-
-- On `Android` allows TalkBack to announce **in list**/**out list** or **in grid**/**out of grid**
-
-### TalkBack
-
-<TalkBackList />
-
-To provide this accessibility feature, AMA wraps the list in the custom native
-component: [ListWrapper](./ListWrapper.mdx).
-
 
 ## Additional props
 

diff --git a/packages/lists/src/components/DynamicFlatList.tsx b/packages/lists/src/components/DynamicFlatList.tsx
@@ -2,7 +2,6 @@ import React from 'react';
 import { FlatList, FlatListProps } from 'react-native';
 
 import { useDynamicList } from '../hooks/useDynamicList';
-import { ListWrapper } from './ListWrapper';
 
 type DynamicFlatListProps<T> = FlatListProps<T> & {
   singularMessage: string;
@@ -27,22 +26,14 @@ export const DynamicFlatList = React.forwardRef<
     });
 
     return __DEV__ ? (
-      <ListWrapper
-        rowsCount={dynamicList.rowsCount}
-        columnsCount={dynamicList.columnsCount}>
-        <FlatList
-          data={data}
-          {...rest}
-          ref={forwardedRef}
-          style={dynamicList.style}
-        />
-      </ListWrapper>
+      <FlatList
+        data={data}
+        {...rest}
+        ref={forwardedRef}
+        style={dynamicList.style}
+      />
     ) : (
-      <ListWrapper
-        rowsCount={dynamicList.rowsCount}
-        columnsCount={dynamicList.columnsCount}>
-        <FlatList data={data} {...rest} ref={forwardedRef} />
-      </ListWrapper>
+      <FlatList data={data} {...rest} ref={forwardedRef} />
     );
   },
 );
diff --git a/packages/lists/src/components/ListWrapper.android.test.tsx b/packages/lists/src/components/ListWrapper.android.test.tsx
diff --git a/packages/lists/src/components/ListWrapper.ios.test.tsx b/packages/lists/src/components/ListWrapper.ios.test.tsx
diff --git a/packages/lists/src/components/ListWrapper.tsx b/packages/lists/src/components/ListWrapper.tsx
diff --git a/packages/lists/src/components/StaticFlatList.tsx b/packages/lists/src/components/StaticFlatList.tsx
@@ -1,8 +1,6 @@
 import React from 'react';
 import { FlatList, FlatListProps } from 'react-native';
 
-import { ListWrapper } from './ListWrapper';
-
 export type StaticFlatListProps = {
   rowsCount?: number;
   numColumns?: number;
@@ -24,9 +22,5 @@ export const StaticFlatList = React.forwardRef<
     return Math.ceil(columns > 1 && length > 0 ? length / columns : length);
   }, [columns, data?.length, rowsCount]);
 
-  return (
-    <ListWrapper rowsCount={rows} columnsCount={columns}>
-      <FlatList data={data} {...rest} ref={ref} />
-    </ListWrapper>
-  );
+  return <FlatList data={data} {...rest} ref={ref} />;
 });
diff --git a/packages/lists/src/index.ts b/packages/lists/src/index.ts
@@ -1,7 +1,6 @@
 // Components
 export { DynamicFlatList } from './components/DynamicFlatList';
 export { FlatList } from './components/FlatList';
-export { ListWrapper } from './components/ListWrapper';
 export { StaticFlatList } from './components/StaticFlatList';
 
 // Hooks