Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add One Light and One Dark Themes #224

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

mrousavy
Copy link
Contributor

fixes: #218

@gksander
Copy link
Contributor

Hi @mrousavy – thanks for contributing this. As an avid OneDark user, I really appreciate this 😄 I pulled down your branch and integrated the new themes into the demo, but most tokens seem to be getting colored with the hsl(220, 14%, 71%) line so things don't look quite right. I'm going to poke around a bit to see what it takes to get the additional colors in the right place.

image

@gksander
Copy link
Contributor

gksander commented Sep 26, 2023

Added a few tweaks to oneDark and oneLight:

image

image

And added a changeset record so we can release this into the wild once merged.

Copy link
Contributor

@carloskelly13 carloskelly13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the demo, both look great. Thank you for adding these two new themes!

@gksander gksander merged commit bb2d7b3 into FormidableLabs:master Sep 26, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
@gksander
Copy link
Contributor

Okay, these changes should be live with version 2.1.0 🥳

@mrousavy
Copy link
Contributor Author

Ah yeah I think I messed something up with the colors, my fault!!

I'll try with your changes in a second to double check if both themes look correct, orherwise I'll send another PR!

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme : OneDark
3 participants