Avoid the empty div wrapper for 'null' custom controls #561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation
None element is rendered when a
render*Controls
prop innull
but when it is afunction that returns null
the control div wrapper is rendered empty:Use case: Removing the previous/next controls when they are not needed returning null depending on
currentSlide
andslideCount
renders the empty div wrapper causing pointer-events problems.The proposal
This PR renders the div wrapper and the element (returned by the
render*Controls
prop) only when therender*Controls
prop is a function and that function is not returning null/false.