Fix calculation of dimensions, fixes #495 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnisbelte-home24
approved these changes
Apr 10, 2019
|
@karolisgrinkevicius-home24 thank you for submitting this fix - we have some other issues' fixes in the works this week so I will likely release this by Friday! |
|
Thanks @sarmeyer. This PR sadly introduces IE11 |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will probably fix not only one re-calculation issue in the list since this includes implementation that observes for new mutations across child nodes and sets new width and height for the slides.
Fixes #495
Type of Change
How Has This Been Tested?
In order to be able to write unit tests for MutationObserver API I had to upgrade some dependencies and specifically resolve
jsdom@^14.0.0which has it's the implementation already.