Fix speed slide flicker #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also fixes #502 |
|
Thx @sarmeyer ! |
|
You're welcome - working on the release now |
3 tasks
|
@lauterry 4.4.9 released! |
|
@sarmeyer thanks ! |
|
The issue seems to back in |
|
Issue is present even on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@lauterry opened the issue #493 and it also happened to me. When we scroll on the carousel sometimes it just pop to the next image very quickly. The issue comes from the fix of PR #458 where the
resetWrapAroundPositionstate is set to true which changes thedurationvariable to 0 instead of taking the speed props. My fix is to get theresetWrapAroundPositionstate only if the propswrapAroundis enabled.Fixes #493
Type of Change