Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update [WIP] #487

Merged
merged 5 commits into from
Jan 22, 2019
Merged

README update [WIP] #487

merged 5 commits into from
Jan 22, 2019

Conversation

johannam999
Copy link
Contributor

@johannam999 johannam999 commented Jan 22, 2019

Description

Documentation update after testing Nuka.
Changes:
Specified Node.js version to run in order to initiate the demo.
Information on the default props settings for control buttons (Prev/Next), Paging dots and for Keyboard shortcuts.
Detailed information on ARIA announcement message.

Type of Change

Please delete options that are not relevant.

  • A documentation update

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@sarmeyer sarmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the keyboardControls note

Copy link
Member

@sarmeyer sarmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these changes!

@johannam999 johannam999 merged commit 0186524 into master Jan 22, 2019
@johannam999 johannam999 deleted the task/documents-update branch January 22, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants