Add TypeScript types #477
Merged
Add TypeScript types #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarmeyer
approved these changes
Jan 10, 2019
2 tasks
|
@kale-stew @sarmeyer looks like index.d.ts is not present on npm |
|
thanks @sarmeyer fixed on 4.4.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes the existing type definitions from DefinitelyTyped and ships them with the library instead. This will make it easier to update these definitions as the nuka-carousel API evolves.
In addition to bringing in the types, we've set up tslint and tsc to help verify changes to the
index.d.ts.Once this PR merges, we can PR for the existing definitions to be removed from DT.
Rel #395
Type of Change
How Has This Been Tested?
Tested with a local sample of nuka-carousel and within the
demo/app.jsapp.tsx.