Fix click event handler on button within slide element #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the click event handler for buttons that are within the slide elements. Clicking a button was firing the
handleSwipe
method, when it should only fire it's own onClick handler. By checking onMouseUp if there is a direction on the click event, we can avoid unnecessary swipe method calls.Fixes #462
Type of Change
How Has This Been Tested?
Add a button to the slides with an onClick handler that changes the slideIndex
Checklist: (Feel free to delete this section upon completion)
yarn lint
)yarn test
andyarn test-e2e
)