-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initial height #469
Fix initial height #469
Conversation
@vyteniskuciauskas-home24 Just finished testing this and it works great. Thanks for taking the time to submit this PR and doing the work of responding to the issues related. I'll cut a release with this fix in since it's such a needed bug fix! |
Oh wow I have been watching some of those bugs for literally years - almost sad to see them go ;) Thanks for this! |
Do you know when the release will be live ? |
@IMFIL release 4.4.5 live today |
I'm still seeing the issue, and it kindof went away when I set |
I'm still fighting with this error too. @wereHamster your workaround doesn't work fine, sometimes the content inside slide go out from screen because this width setted. |
Same here, height is still 0 when routes change (via browser history). |
Doesn't seem to be fixed for me |
Looks like it is still an issue with |
Also still having this issue with Temporary fix was to wrap my
|
You can try this workaround to set fixed height and aspect ratio. |
Still having issues with height on initial render |
Trying to fix initial height bug
This should fix the following reproducible issue: https://codesandbox.io/s/0qr88707wp
Closes #202 #457 #417 #103