Fix initial height

[ghost]

Trying to fix initial height bug
This should fix the following reproducible issue: https://codesandbox.io/s/0qr88707wp

Closes #202 #457 #417 #103

[sarmeyer]

@vyteniskuciauskas-home24 Just finished testing this and it works great. Thanks for taking the time to submit this PR and doing the work of responding to the issues related. I'll cut a release with this fix in since it's such a needed bug fix!

[stefangordon]

Oh wow I have been watching some of those bugs for literally years - almost sad to see them go ;)

Thanks for this!

[IMFIL]

Do you know when the release will be live ?

[sarmeyer]

@IMFIL release 4.4.5 live today

[wereHamster]

I'm still seeing the issue, and it kindof went away when I set width:100vw on the slides. I didn't investigate much further.

[eduardoabpereira]

I'm still fighting with this error too. @wereHamster your workaround doesn't work fine, sometimes the content inside slide go out from screen because this width setted.

[yyynnn]

Same here, height is still 0 when routes change (via browser history).

[flikQ]

Doesn't seem to be fixed for me

[aamorozov]

Looks like it is still an issue with v4.4.7, needs a hack to actually set the height of the container on the initial load.

[SummitPatel]

Also still having this issue with 4.4.7.

Temporary fix was to wrap my Review component (i.e. the slides of the carousel) in a div with a height set:

export const ReviewsCarousel = props => (
  <Carousel heightMode={"max"}>
    {props.reviews.length &&
      props.reviews.map((review, i) => {
        return (
          <div style={{ height: 200 }}>
            <Review
              key={i}
              content={review.attributes.review}
              rating={review.attributes.rating}
            />
          </div>
        );
      })}
  </Carousel>
);

[Blobson]

You can try this workaround to set fixed height and aspect ratio.

[jibin2706]

Still having issues with height on initial render