Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue about update props on beforeSlide #453

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Fix issue about update props on beforeSlide #453

merged 1 commit into from
Dec 6, 2018

Conversation

sjfkai
Copy link
Contributor

@sjfkai sjfkai commented Nov 13, 2018 •
edited
Loading

Description

Slide will not change when update props on beforeSlide .

we should use arrow function when update state with previous state.

Fixes #452

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist: (Feel free to delete this section upon completion)

  • My code follows the style guidelines of this project (I have run yarn lint)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test and yarn test-e2e)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

sarmeyer
sarmeyer approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@sarmeyer sarmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks!

@sarmeyer sarmeyer merged commit f2c2623 into FormidableLabs:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarmeyer sarmeyer sarmeyer approved these changes

@akhil-gautam akhil-gautam akhil-gautam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slide will not change when update props on beforeSlide
3 participants
@sjfkai @sarmeyer @akhil-gautam