Skip to content

Add support for accessibilityIgnoresInvertColors #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 9, 2020

Conversation

VirtualDOMinic
Copy link
Contributor

closes #63

Added isNodePropValueBoolean (see explanation added as comment inside the function). Do let me know if you're happy with the function! It works with the tests and even accounts for the implicit ={true} of using the prop name by itself (e.g. <View accessibilityIgnoresInvertColors></View>).

Also strayed from the other tests a bit by using an array of just strings and then mapping to turn these into the {code: ..., errors: [...]} object, as I find this nicer to read and edit. Happy to make it more in line with the other rule tests if you'd prefer.

@jpdriver jpdriver merged commit 15b882d into master Feb 9, 2020
@jpdriver jpdriver deleted the support-accessibilityIgnoresInvertColors-prop branch February 9, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for accessibilityIgnoresInvertColors
2 participants