Support for ESLint version ^6 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved in #51 and causes tests to crash with eslint ^6.
jpdriver
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this package logs a warning if used with eslint v6 as that is above peer dependencies listen in package json.
This pull request fixes that by adding eslint ^6 to peer dependencies.
Also removed two eslint-disable-line comments in
scripts/create-rule.jsas the disabled rule was removed in #51 and would result in a crash during tests with eslint ^6.Thanks
EDIT: Removed node 6 from travis config as that is no longer supported in eslint 6 and failed ci tests. Instead added node 12 as that is now LTS.