-
Notifications
You must be signed in to change notification settings - Fork 7
Complete Upgrade: Babel 6 / React 0.14.x / Node 5.4/ react-transform-hmr / all dependencies are up to date #46
base: master
Are you sure you want to change the base?
Complete Upgrade: Babel 6 / React 0.14.x / Node 5.4/ react-transform-hmr / all dependencies are up to date #46
Conversation
…transform-hmr - Implemented - No modification to the existing code structure beside webpack related / enviroment specific. TODO: Structural Code Modification needed on /client/components/error-panel.jsx && /client/components/output-panel.jsx && /client/components/types.jsx as they are not React 0.14.x compliant which results in: TypeError: ... Property value of JSXAttribute expected node to be of a type ['JSXElement','StringLiteral','JSXExpressionContainer'] but instead got 'CallExpression'
|
Work-In-Progress - Submittal for reference as objections/suggestions are addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove trailing commas.
|
@bartekus -- Thanks for the initial WIP work! I've got a few preliminary comments. Also, I think the Ultimately, get CI cleaned up such that it correctly runs on your machine. The last stuff with Karma through Sauce will fail because Travis won't allow you to use this repo's secret credentials via a forked PR (I'll hook up that last part when we're at that stage of the process). |
in order to trigger them. I've also removed .babelrc and moved the setting to webpack.config.
These are the last 3 errors (+ 2 warnings) present that I can spot by npm run check && npm run dev As to linting standards: |
|
@bartekus -- I think it's perhaps better to focus on just the upgrade. Offhand, a couple of things to keep in mind:
Ideally, the best approach, infrastructure-wise is "change the structure of files" + "touch things" as little as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an actual version? (Sorry if I led you astray, I was giving pseudocode in earlier comment)
Surface Upgrade Completed:
Webpack Modification (WIP)
webpack.config.coverage.js
webpack.config.hot.js
webpack.config.js
Environment specific
TODO:
Structural Code Modification needed on:
/client/components/error-panel.jsx
/client/components/output-panel.jsx
/client/components/types.jsx
Currently not React 0.14.x compliant which results in:
TypeError: ... Property value of JSXAttribute expected node to be of a type ['JSXElement','StringLiteral','JSXExpressionContainer'] but instead got 'CallExpression'