Infra: Upgrade project to terraform 0.12

[ryan-roemer]

Work

• Take our terraform0.12 branch to master as the official release.
• Add hints for terraform-aws-serverless development against this project.
• Add a full script for yarn _dev:on|off helpers for easy local development of terraform-aws-serverless
• Update to terraform-aws-serverless@1.0.0

Testing

• Full tf init / apply verifies no changes originally against Kevin's deploy.
• Did tf apply an IAM change needed for newer serverless
• Developer lambda deploy succeeded.

# Service update
$ STAGE=sandbox aws-vault exec USER.NAME --no-session -- \
  yarn tf:service:init --reconfigure && \
  STAGE=sandbox aws-vault exec USER.NAME --no-session -- \
  yarn tf:service:apply

# Lambda / serverless
$ STAGE=sandbox aws-vault exec USER.NAME-developer --no-session -- \
  yarn lambda:deploy

Tasks

• Merge and publish Migrate to TF 12 terraform-aws-serverless#67
• Run yarn _dev:off in this branch and upgrade all versions of the module to the new release.

Notes

Running yarn _dev:off then git diff produces this (showing how we disable the "development mode" against terraform-aws-serverless):

diff --git a/terraform/main.tf b/terraform/main.tf
index 7ed599b..027a538 100644
--- a/terraform/main.tf
+++ b/terraform/main.tf
@@ -41,8 +41,8 @@ JSON
 # Base `serverless` IAM support
 ###############################################################################
 module "serverless" {
-  source = "../../terraform-aws-serverless"
-  # version = "0.8.8"
+  source = "FormidableLabs/serverless/aws"
+  version = "0.8.8"
 
   region       = var.region
   service_name = var.service_name
@@ -77,8 +77,8 @@ module "serverless" {
 # OPTION(xray): Add X-ray support to lambda execution roles.
 ###############################################################################
 module "serverless_xray" {
-  source = "../../terraform-aws-serverless//modules/xray"
-  # version = "0.8.8"
+  source = "FormidableLabs/serverless/aws//modules/xray"
+  version = "0.8.8"
 
   # Same variables as for `serverless` module.
   region       = var.region
@@ -216,8 +216,8 @@ STACK
 
 # OPTION(vpc): Add in IAM permissions to humans + lambda execution role.
 module "serverless_vpc" {
-  source = "../../terraform-aws-serverless//modules/vpc"
-  # version = "0.8.8"
+  source = "FormidableLabs/serverless/aws//modules/vpc"
+  version = "0.8.8"
 
   # Same variables as for `serverless` module.
   region       = var.region
@@ -287,8 +287,8 @@ STACK
 
 # OPTION(canary): Add serverless-plugin-canary-deployments to lambda execution roles.
 module "serverless_canary" {
-  source = "../../terraform-aws-serverless//modules/canary"
-  # version = "0.8.8"
+  source = "FormidableLabs/serverless/aws//modules/canary"
+  version = "0.8.8"
 
   # Same variables as for `serverless` module.
   region       = var.region

[kevinmstephens]

Ran through the test steps and everything looks good. Nice work! 🚢

[kevinmstephens]

👏