Skip to content

Conversation

@brianbattformant
Copy link
Collaborator

This pull request introduces a set of new appearance and layout customization props to the ViewEmbedWrapper and related components, allowing users to control font, spacing, border radius, animation, and loading behavior. These enhancements improve flexibility for embedding and styling views, and also add support for custom loading components. The changes are reflected in both the main wrapper and the embedding utility, ensuring consistent prop handling and forwarding.

Appearance & Layout Customization:

  • Added new props to ViewEmbedWrapper and EmbedWithHooks for font family, font size, font weight, line height, border radius, module spacing/padding, shadow size, container max width, grid columns, grid row height, and animation/transitions options. These props are now included in the interface and destructured from props for usage and forwarding. [1] [2] [3] [4]
  • All new appearance props are forwarded via postMessage to the embedded iframe, ensuring that the embedded view receives and can apply these customizations. [1] [2] [3]

Loading State Improvements:

  • Added support for a customLoadingComponent and customLoadingIconUrl prop, rendering a custom loading overlay until the iframe is loaded. This overlay is styled to cover the iframe area and uses the background from wrapperStyleOverride if provided. [1] [2] [3] [4] [5] [6] [7]

Prop Handling & Forwarding:

  • Updated prop merging logic in EmbedWithHooks to use a unified mergedToken for authentication, and ensured all new customization props are passed to ViewEmbedWrapper. [1] [2]

Documentation:

  • Added a new markdown documentation file, INTERACTIVE_STATES_FEATURE.md, describing all new interactive state and chart color customization features, usage examples, implementation details, and testing instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants