Skip to content

Commit

Permalink
ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
Browse files Browse the repository at this point in the history
platform_get_irq() returns an error code, but the ac97c
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.

Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
GustavoARSilva authored and tiwai committed Jul 1, 2017
1 parent 1967158 commit 7720113
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/atmel/ac97c.c
Original file line number Diff line number Diff line change
Expand Up @@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_dbg(&pdev->dev, "could not get irq\n");
return -ENXIO;
dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
return irq;
}

pclk = clk_get(&pdev->dev, "ac97_clk");
Expand Down

0 comments on commit 7720113

Please sign in to comment.