Repository navigation
Conversation
Apply common checks to eligible pages and separate declared page scope from detected advisory findings. Add selected-page coverage and a generated audit index. BREAKING CHANGE: content becomes a legacy general-page declaration. Use article to select article obligations. Audit applicability and report contracts target 7.0.0 across all published packages.
Review fixes for the v7 applicability runner: - Put the scan target first in each audit's page set and sort the rest by code point, so `pages[0]` is the requested URL again and the order no longer depends on the host locale (`CheckContext.targetUrl`). - Tag a declared population whose every fetch failed `skipped:page-type`, so a 404 no longer counts toward the gated-mass unscored threshold. - Turn a custom audit with conflicting page-type aliases into its own scan-error stub instead of aborting the scan. - List per-audit coverage only for typed, advisory, partly unread or failing audits, so MCP and report output no longer carry ~215 URL lists. - Drop the never-produced legacy `content` type from ten scope lists and remove the always-true `isArticlePage` helpers. Enums: - Every public string union in core is now a const object plus a type of the same name (CheckStatus, PageType, EvidenceKey, AuditTier, ...), and the Zod schemas read their values from those objects. - 26 module-local unions became enums, 3 became constant lists, and 4 duplicated unions now share one definition (HttpMethod, RuleStatus, SkipReason, StoreStatus). - `AuditMetaSchema` validates page types against the enum. `pnpm check:enums` uses the TypeScript checker to reject a string literal wherever an enum is expected and any new string-literal union. It runs in CI and is documented in CLAUDE.md.
Replace climbing relative imports (`../../types`) inside packages/core/src with `#core/<path>`, a Node subpath import declared in the core package.json. 518 files change; same-folder `./x` imports stay. The mapping has three conditions: - `agent-lighthouse-source` (a repo-only custom condition set in tsconfig.base.json) resolves TypeScript to `src/*.ts`; - `types` resolves package users' TypeScript to `dist/*.d.ts`, because the emitted declarations keep the alias; - `default` resolves Vite, tsx and esbuild to `src/*.ts`; the published bundle inlines every import, so it never resolves the alias at run time. The named `#core/*` prefix is used instead of `#/*` because the published declarations are read by package users' TypeScript, and `#/` resolves only on TypeScript 6.0 or newer.
4 tasks done
Map `#core/*` in the root package.json to packages/core/src, so scripts import core source as `#core/<path>` instead of `../packages/core/src/...` (16 files, plus the five scripts that imported the core entry as `#core/index`). Enforce both forms with oxlint's no-restricted-imports: a climbing `../` import inside packages/core/src and a `packages/core/src` path inside scripts are errors. The one test that imports a script from outside core carries a commented suppression.
The fixture's package.json had no packageManager field, so the fixture ran whatever pnpm the machine had globally. Under pnpm 11, `pnpm exec prettier` (called by changesets) checks the dependency state first and refuses the linked node_modules with ERR_PNPM_UNSAFE_MODULES_DIR. CI passed on pnpm 10; local runs failed. Copy the root packageManager into the fixture.
A product page with a "recently viewed" rail read as a category page, so every product audit was skipped. Four gaps combined: each part of one tile that repeats the card class counted as a card, rail cards counted toward a grid, carousel dots counted as result pagination, and a grid outranked the page's own product evidence. - The page's own product evidence (og:type=product, exactly one top-level product entity, or buy controls outside listing cards) outranks a grid. - One top-level Product, ProductGroup, IndividualProduct or ProductModel, from JSON-LD, microdata or RDFa, and no listing schema, adds the strong signal `product-schema-primary`. Several top-level products stay a hint. - Only outermost card matches count, and cards in recommendation, recently viewed, carousel, slider or aside regions do not count toward a grid. - Carousel pagination (swiper, slick) is not result pagination. - Buy controls inside listing cards do not count as the page's own. Once a page has two or more cards, each is a listing card at any wrapping depth; a lone element marked data-product-id, or a card holding the page's <h1>, keeps its controls.
…dits Product audits read only Product nodes, so a brand or category declared once on a ProductGroup was invisible, and offer-schema judged the first Offer node in the page rather than the product's own offers. Both are documented false findings: offer-schema's dossier already named the short-circuit as a required fix. - New `resolveProducts` (packages/core/src/product-schema.ts) returns each variant with the group's shared properties beneath its own, as Google's product variant documentation lays them out. Variants join through hasVariant, isVariantOf or inProductGroupWithID, and @id references in hasVariant and offers are followed. A ProductGroup with no variants is read as the product. - offer-schema, product-identifiers, advanced-product-details, product-transaction-certainty, checkout-offer-field-mapping, landed-cost-and-returns and the product field summary use it. - offer-schema passes on any priced offer reachable from the page's products: an Offer with price, an AggregateOffer with lowPrice, or an Offer whose itemOffered names the product, nested or by @id. - checkout-offer-field-mapping reads an image list by its first URL. - landed-cost-and-returns reads microdata and RDFa, as its dossier states, and takes the product's own offer before any other Offer node. Dossiers record each change under Implementation deviations. Two corpus verdicts move on the SaaS plans fixture: offer-schema fail -> pass (its priced offers sat behind an empty first Offer stub) and landed-cost-and-returns na -> fail (its products are microdata, which the audit previously ignored).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Common audits could skip readable interior pages when a scan had no readable homepage. Broad
contentclassification also applied article obligations to general pages. This migration applies common checks to eligible pages and adds purpose-specific checks only to their selected populations.articleandunknown, classification provenance, stable page identity, and shared declaration validation across SDK, CLI, config, and MCP. Keep legacycontentaccepted as a general-page declaration; callers must usearticleto select article obligations.advisoryResults. Evaluate evidence against selected URLs, retain unread pages and failed attempts, and count each audit once for scoring, progress, and tracing.docs/evidence/audit-map.json, including purpose, features, applicability, evidence, scoring, and source/test/dossier paths. Enforce agreement with the registry.Validation
All seven repository gates passed locally in order: build, test, typecheck, lint, dossiers, requirements, and audit map. The committed product source matches the validated source fingerprint.
The corpus replay uses saved responses and synthetic secondary-resource failures; it is not a full crawl or a public site-score comparison. Live invariants prove report consistency, not every finding's correctness. Existing ledger deferrals remain outside this migration. CI results are separate from this local proof.
Review entry points:
Type of Change
Affected Packages
@forkpoint/agent-lighthouse(CLI)@forkpoint/agent-lighthouse-core@forkpoint/agent-lighthouse-report@forkpoint/agent-lighthouse-mcppackages/websiteChecklist
pnpm buildpnpm testpnpm typecheckpnpm lintpnpm check:dossierspnpm check:requirespnpm check:audit-mappnpm exec changeset status.