Skip to content

Conversation

@ryanbas21
Copy link
Collaborator

@ryanbas21 ryanbas21 commented Jun 16, 2025

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4164

Description

NodeStates was missing from api file

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2025

🦋 Changeset detected

Latest commit: 0ea7df7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@forgerock/davinci-client Patch
@forgerock/oidc-client Patch
@forgerock/sdk-types Patch
@forgerock/sdk-utilities Patch
@forgerock/iframe-manager Patch
@forgerock/sdk-logger Patch
@forgerock/sdk-oidc Patch
@forgerock/sdk-request-middleware Patch
@forgerock/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Jun 16, 2025

View your CI Pipeline Execution ↗ for commit 0ea7df7.

Command Status Duration Result
nx run-many -t build ✅ Succeeded <1s View ↗
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 43s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-17 16:22:01 UTC

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Deployed 7688057 to https://ForgeRock.github.io/ping-javascript-sdk/pr-332/76880574c446188d7fc8f43dbfb22ab2273f9d04 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.61%. Comparing base (37f73bf) to head (0ea7df7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   61.61%   61.61%           
=======================================
  Files          33       33           
  Lines        1985     1985           
  Branches      287      288    +1     
=======================================
  Hits         1223     1223           
  Misses        762      762           
Files with missing lines Coverage Δ
packages/davinci-client/src/types.ts 50.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 force-pushed the add-node-states-back branch from 08c5c7b to 0ea7df7 Compare June 17, 2025 16:18
@ryanbas21 ryanbas21 merged commit 17171a5 into main Jun 17, 2025
3 checks passed
@ryanbas21 ryanbas21 mentioned this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants