Skip to content

Conversation

@ryanbas21
Copy link
Collaborator

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-4042

Description

Error states should clear once we have successfully processed a success or next node.

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: fb041e0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@forgerock/davinci-client Patch
@forgerock/oidc-client Patch
@forgerock/sdk-types Patch
@forgerock/sdk-utilities Patch
@forgerock/iframe-manager Patch
@forgerock/sdk-logger Patch
@forgerock/sdk-oidc Patch
@forgerock/sdk-request-middleware Patch
@forgerock/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link
Contributor

nx-cloud bot commented May 13, 2025

View your CI Pipeline Execution ↗ for commit fb041e0.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-02 17:25:54 UTC

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Deployed 0df3260 to https://ForgeRock.github.io/ping-javascript-sdk/pr-277/0df326011be4fc1537c878b861495656909040c7 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.32%. Comparing base (6e2bce8) to head (fb041e0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   50.26%   50.32%   +0.05%     
==========================================
  Files          29       29              
  Lines        1711     1713       +2     
  Branches      195      194       -1     
==========================================
+ Hits          860      862       +2     
  Misses        851      851              
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/collector.utils.ts 84.97% <100.00%> (ø)
packages/davinci-client/src/lib/davinci.types.ts 100.00% <ø> (ø)
packages/davinci-client/src/lib/node.slice.ts 78.44% <100.00%> (+0.19%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@cerebrl cerebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think it needs to be rebased with main as it contains commits that are likely already in the base branch.

@ryanbas21 ryanbas21 force-pushed the clear-error-state-when-successful-request branch 3 times, most recently from 72ca540 to 637e14b Compare June 2, 2025 15:25
@ryanbas21 ryanbas21 force-pushed the clear-error-state-when-successful-request branch from 637e14b to fb041e0 Compare June 2, 2025 17:23
@ryanbas21 ryanbas21 marked this pull request as ready for review June 2, 2025 17:30
@ryanbas21 ryanbas21 merged commit 4ec5c25 into main Jun 2, 2025
3 checks passed
@ryanbas21 ryanbas21 mentioned this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants