fix(davinci-client): update-type-misalignments #267
Conversation
🦋 Changeset detectedLatest commit: 12179a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 12179a1.
☁️ Nx Cloud last updated this comment at |
|
Deployed eca3bde to https://ForgeRock.github.io/ping-javascript-sdk/pr-267/eca3bdea139dc6a712dd125defefbb3d0afb0bf6 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (12.50%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 47.35% 55.34% +7.99%
==========================================
Files 29 20 -9
Lines 1472 1384 -88
Branches 148 164 +16
==========================================
+ Hits 697 766 +69
+ Misses 775 618 -157
🚀 New features to boost your workflow:
|
| client: { | ||
| action: '', | ||
| collectors: [], | ||
| status: 'error', | ||
| }, | ||
| cache: { | ||
| key: '', | ||
| }, | ||
| httpStatus: 200, |
There was a problem hiding this comment.
Let's just add the proper DaVinciError to the StartNode, and then you wouldn't have to recreate this whole object. Then you could just add the error to the existing nodeCheck and return it.
There was a problem hiding this comment.
this object still needs to be recreated though because to satisfy an ErrorNode we need things like cache, and the client keys as well as the httpStatus and the server to be a status of error.
ryanbas21
force-pushed
the
type-fixes
branch
2 times, most recently
from
30c9eb1 to
2d040e8
Compare
| "declaration": true, | ||
| "declarationMap": true, | ||
| "skipLibCheck": true, | ||
| "skipLibCheck": false, |
There was a problem hiding this comment.
i'm unsure about the importance of this change, its probably worth us having it anyways because if theres a bug in an RTK version we are using we probably want to catch it here in our code before publishing.
this setting just checks the library types also
|
|
||
| export const buildPackages = Command.make('pnpm', 'build').pipe( | ||
| Command.lines, | ||
| Command.string, |
There was a problem hiding this comment.
formats output better than lines
| }), | ||
| Effect.asVoid, | ||
| ); | ||
| ).pipe(Command.exitCode); |
There was a problem hiding this comment.
if we get a 1 exit code we fail.
tools/release/release.ts
Outdated
|
|
||
| const program = Effect.gen(function* () { | ||
| yield* Console.log('Starting release script...'); | ||
| yield* Console.log('Starting release script...', process.cwd()); |
There was a problem hiding this comment.
i can remove, it just was me sanity checking the working directory.
fixing a couple misalignments on NodeStates and continue fallback
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4007
Description
fixing a couple misalignments on NodeStates and continue fallback