Repository navigation
feat: Add support in custom resource for labels and annotations - #118
Merged
Merged
Conversation
Add support for labels and annotations in the DirectoryService spec. Add support for labels in the pod spec. ref: FORGEOPS-4672
lee-baines
force-pushed
the
FORGEOPS-4672-annotation-and-label-support
branch
from
November 26, 2023 18:02
818d344 to
24ddff9
Compare
lee-baines
commented
Nov 26, 2023
| "k8s.io/client-go/rest" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest/printer" |
Contributor
Author
There was a problem hiding this comment.
printer package no longer available
lee-baines
commented
Nov 26, 2023
|
|
||
| func TestAPIs(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| // func TestAPIs(t *testing.T) { |
Contributor
Author
There was a problem hiding this comment.
Commenting out as printer package is no longer available. Don't think this test is required so leaving out for now.
lee-baines
commented
Nov 26, 2023
| # See https://github.com/ForgeRock/forgeops/tree/master/docker/ds/ds | ||
| image: us-docker.pkg.dev/forgeops-public/images/ds:dev | ||
| imagePullPolicy: IfNotPresent | ||
| # Uncomment below to configure imagePullSecrets for access to a container registry |
Contributor
Author
There was a problem hiding this comment.
Adding there was nothing to indicate this was available
Contributor
Author
|
Need to fix https://bugster.forgerock.org/jira/browse/FORGEOPS-4706 before merging. |
damonconway
approved these changes
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for labels and annotations in the DirectoryService spec. Add support for labels in the pod spec.
ref: FORGEOPS-4672