[16.0][IMP] rma: Fix calculation for qty_to_receive

[JasminSForgeFlow]

Backport from 18.0

[AaronHForgeFlow]

For me this is ok, as it is merged in v18. In v16 there is this other proposal: #619 but I think we can merge this other because it is already proposed to v17 and merged in v18

[LoisRForgeFlow]

Thanks Jasmin! we'll merge after closing v18 migration

[florian-dacosta]

Thanks.
Has the same been done for qty_to_deliver ?

[JasminSForgeFlow]

Thanks. Has the same been done for qty_to_deliver ?

That's working okay, no need for it

[florian-dacosta]

Thanks. Has the same been done for qty_to_deliver ?

That's working okay, no need for it

Are you sure ?
As far as I know, the problem is exactly the same.
If you have a rma line with product_qty = 1. the qty_to_deliver is also 1 / qty_outgoing is 0 Then you generate the delivery order, the qty_to_deliver is still 1 and the qty_outgoing is also 1 (#623 (comment)) while the qty_to_deliver should probably goes to 0, as it happens with the qty_to_receive in the case of incoming shipments, with this PR, right ?

For me the qty_to_receive and the qty_to_deliver work exactly the same, so the problem is the same, and it would be really weird if the field would some times take into account the incoming/outgoing qty and sometime not !
But I may have misunderstood some part or maybe we do not have the same issue in mind around this field...
Could you elaborate please ?

[JasminSForgeFlow]

Thanks. Has the same been done for qty_to_deliver ?

That's working okay, no need for it

Are you sure ? As far as I know, the problem is exactly the same. If you have a rma line with product_qty = 1. the qty_to_deliver is also 1 / qty_outgoing is 0 Then you generate the delivery order, the qty_to_deliver is still 1 and the qty_outgoing is also 1 (#623 (comment)) while the qty_to_deliver should probably goes to 0, as it happens with the qty_to_receive in the case of incoming shipments, with this PR, right ?

For me the qty_to_receive and the qty_to_deliver work exactly the same, so the problem is the same, and it would be really weird if the field would some times take into account the incoming/outgoing qty and sometime not ! But I may have misunderstood some part or maybe we do not have the same issue in mind around this field... Could you elaborate please ?

Here I have created one RMA order, Qty to receive is 1 and other all are 0

I have create shipment, haven't validated yet

After validating shipment

It show Qty to delivery 1 only after shipment validated.