[17.0][MIG] rma_scrap #514
Conversation
|
Tested scrap operations with the scrap completion. LGTM (I am not reviewing myself, the migration was done in the superseded PR) |
|
There is only one issue with the rma_scrap view, with some fields not being displayed (I think they can be removed from the view)
|
…ranch Push code from unmerger PR: ForgeFlow#514 Branch: https://github.com/ForgeFlow/stock-rma/tree/17.0-mig-rma_scrap-good
|
@AaronHForgeFlow Found a minor issue with creating a scrap order from the RMA order. If the product to be scrapped is serial tracked, the scrap form view makes the quantity field readonly. There's an onchange on the product_id field that is supposed to set the quantity to 1 if the product is serial tracked, but it is not triggered. The result is that the quantity is set to 0 and is readonly. Calling the onchange method after creating the scrap order should fix this. |
|
@RLeeOSI thanks for the notice! I will fix that. Anyway, if you create a PR to my branch I would appreciate it. |
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_scrap-good
branch
from
d545bfe to
085d05f
Compare
|
@RLeeOSI I see that in the Scrap order the quantiy is readonly, but it seems that is standard Odoo. When the product is serial tracked then the quantity is readonly. In the wizard, I can see I can put a different quantity even if the product is serial: This quantity is propagated to the scrap order and can't be changed: So the solution I think is to force the quantity in the wizard to be 1. Same as Odoo does with manual scrap orders. |
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_scrap-good
branch
from
085d05f to
94892e7
Compare
|
Rebasing just to confirm tests fail and the module needs an amendment. |
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_scrap-good
branch
from
94892e7 to
97b62c0
Compare
rma_scrap/models/stock_scrap.py
Outdated
| result["res_id"] = self.rma_line_id.id | ||
| return result | ||
|
|
||
| def action_validate(self): |
There was a problem hiding this comment.
@ThiagoMForgeFlow do your comment for v18 also apply here? #562 (review)
There was a problem hiding this comment.
I removed it, it does not change anything so I think it was a mistake
There was a problem hiding this comment.
Well, I have to look into it deeper. It seems tests fail if that code is removed (tests does not fail in local 😢 )
[FIX] rma_scrap: ensure scrapping serials will scrap just 1 unit & ensure scrapped quantity is always positve [FIX] rma_scrap: scrap quantity should consider the quantity in the stock moves not the product_uom_qty [IMP] rma_scrap: test serial case [FIX] rma_scrap: remove incorrect action_validate method overwrite and do minor fix in view fixup
AaronHForgeFlow
force-pushed
the
17.0-mig-rma_scrap-good
branch
from
97b62c0 to
0705f3e
Compare
Supersedes #504
Respected original code & history
Reasons for supersede:
Merge 17.0 was broken after merging and reverting by mistake some pull requests: #483 & #500
History was incorrect showing merge commits within it.
Merge conflicts when trying to manually merge other PRs on top on that one.
Unable to see the changes in the migration commit, making hard for the reviewer to review the code
Sorry for the inconvenience.
https://github.com/ForgeFlow