Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): replace the hard-coded duration by the duration variable #621

Merged
merged 2 commits into from
May 23, 2023

Conversation

nicolasalexandre9
Copy link
Member

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@nicolasalexandre9 nicolasalexandre9 changed the title fix(operator): replace the hardcoded duration by the variable fix(operator): replace the hard-coded duration by the variable May 22, 2023
@codeclimate
Copy link

codeclimate bot commented May 22, 2023

Code Climate has analyzed commit e3aa48b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (55% is the threshold).

This pull request will bring the total coverage in the repository to 48.7%.

View more on Code Climate.

@nicolasalexandre9 nicolasalexandre9 changed the title fix(operator): replace the hard-coded duration by the variable fix(operator): replace the hard-coded duration by the duration variable May 23, 2023
@nicolasalexandre9 nicolasalexandre9 merged commit 776f23d into main May 23, 2023
@nicolasalexandre9 nicolasalexandre9 deleted the fix/quarter-filter branch May 23, 2023 08:02
forest-bot added a commit that referenced this pull request May 23, 2023
## [8.0.7](v8.0.6...v8.0.7) (2023-05-23)

### Bug Fixes

* **operator:** replace the hard-coded duration by the duration variable ([#621](#621)) ([776f23d](776f23d))
@forest-bot
Copy link
Member

🎉 This PR is included in version 8.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
## [8.0.7](ForestAdmin/forest-rails@v8.0.6...v8.0.7) (2023-05-23)

### Bug Fixes

* **operator:** replace the hard-coded duration by the duration variable ([#621](ForestAdmin/forest-rails#621)) ([776f23d](ForestAdmin/forest-rails@776f23d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants