Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update arel-helpers dependency #535

Merged
merged 1 commit into from
Dec 21, 2021
Merged

fix: update arel-helpers dependency #535

merged 1 commit into from
Dec 21, 2021

Conversation

matthv
Copy link
Member

@matthv matthv commented Dec 20, 2021

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@matthv matthv requested a review from jeffladiray December 20, 2021 10:33
@codeclimate
Copy link

codeclimate bot commented Dec 20, 2021

Code Climate has analyzed commit 8182947 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 44.6% (0.0% change).

View more on Code Climate.

@matthv matthv requested a review from arnaud-moncel December 20, 2021 10:34
@matthv matthv assigned arnaud-moncel and unassigned jeffladiray Dec 20, 2021
@matthv matthv requested review from Scra3 and removed request for jeffladiray and arnaud-moncel December 20, 2021 10:34
@forest-bot
Copy link
Member

Task linked: CU-1p8b6zr 🔥🔥🔥 P1 - Rails - Rails V7 compatibility

@arnaud-moncel arnaud-moncel removed their assignment Dec 20, 2021
@Scra3
Copy link
Member

Scra3 commented Dec 21, 2021 •
edited
Loading

Tests ⛱️ ⛱️ ⛱️ ⛱️ ⛱️

  • Rails 7
  • Rails 6
  • Rails 5

@matthv matthv merged commit 176afff into main Dec 21, 2021
@matthv matthv deleted the fix/update-arel-helpers branch December 21, 2021 14:01
forest-bot added a commit that referenced this pull request Dec 21, 2021
@forest-bot
chore(release): 7.4.3 [skip ci]
820ec7d 
## [7.4.3](v7.4.2...v7.4.3) (2021-12-21)

### Bug Fixes

* update arel-helpers dependency ([#535](#535)) ([176afff](176afff))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arnaudbesnier
Copy link
Contributor

arnaudbesnier commented Dec 22, 2021 •
edited
Loading

A lot of dependencies have been updated here (not only arel), even so major version apparently.
Seems risky to me with the coverage and tests quality we have on this repository.

arnaudbesnier
arnaudbesnier reviewed Dec 22, 2021
View reviewed changes
Gemfile.lock

PLATFORMS
ruby
x86_64-darwin-20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks strange to me too.
It might be a proper fix but it is not related to the initial topic.

matthv added a commit that referenced this pull request Dec 22, 2021
@matthv
fix : Revert "fix: update arel-helpers dependency (#535)"
a7be15f 
This reverts commit 176afff.
matthv added a commit that referenced this pull request Dec 22, 2021
@matthv
fix: revert "fix: update arel-helpers dependency (#535)"
c5049f4 
This reverts commit 176afff.
matthv added a commit that referenced this pull request Dec 22, 2021
@matthv
fix: revert "fix: update arel-helpers dependency (#535)" (#537)
7b75556 
This reverts commit 176afff.
forest-bot added a commit that referenced this pull request Dec 22, 2021
@forest-bot
chore(release): 7.4.4 [skip ci]
8caa7d2 
## [7.4.4](v7.4.3...v7.4.4) (2021-12-22)

### Bug Fixes

* revert "fix: update arel-helpers dependency ([#535](#535))" ([#537](#537)) ([7b75556](7b75556))
alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
@alexcru1012
chore(release): 7.4.3 [skip ci]
c970353 
## [7.4.3](ForestAdmin/forest-rails@v7.4.2...v7.4.3) (2021-12-21)

### Bug Fixes

* update arel-helpers dependency ([#535](ForestAdmin/forest-rails#535)) ([176afff](ForestAdmin/forest-rails@176afff))
alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
@alexcru1012
chore(release): 7.4.4 [skip ci]
e3dd09a 
## [7.4.4](ForestAdmin/forest-rails@v7.4.3...v7.4.4) (2021-12-22)

### Bug Fixes

* revert "fix: update arel-helpers dependency ([#535](ForestAdmin/forest-rails#535))" ([#537](ForestAdmin/forest-rails#537)) ([7b75556](ForestAdmin/forest-rails@7b75556))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbesnier arnaudbesnier arnaudbesnier left review comments

@Scra3 Scra3 Scra3 approved these changes

Assignees

@Scra3 Scra3

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthv @forest-bot @Scra3 @arnaudbesnier @arnaud-moncel @jeffladiray