Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dependency): ensure that project with a groupdate dependency >= 5 can install forest-rails #454

Merged
merged 6 commits into from
May 12, 2021

Conversation

jeffladiray
Copy link
Member

@jeffladiray jeffladiray commented May 3, 2021

(See https://github.com/ForestAdmin/forest-rails/pull/354/files)

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@jeffladiray jeffladiray self-assigned this May 3, 2021
@jeffladiray jeffladiray marked this pull request as ready for review May 3, 2021 13:32
@jeffladiray jeffladiray requested a review from SteveBunlon May 3, 2021 13:32
@arnaudbesnier
Copy link
Contributor

Fix: #440

@jeffladiray
Copy link
Member Author

@arambert @khelal
This should fix #440 - or at least, i'm not able to reproduce with this fix.

If one of you could confirm that it works as expected on your end, it would be awesome 🙌

@jeffladiray jeffladiray requested a review from SteveBunlon May 11, 2021 16:59
@codeclimate
Copy link

codeclimate bot commented May 11, 2021

Code Climate has analyzed commit 63f23b6 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (45% is the threshold).

This pull request will bring the total coverage in the repository to 37.9%.

View more on Code Climate.

@jeffladiray
Copy link
Member Author

Let's merge it then 👍
Still, feel free to ping me here or on the issue if you still encounter an issue with this.

@jeffladiray jeffladiray merged commit 2c0a350 into master May 12, 2021
@jeffladiray jeffladiray deleted the update/groupdate-dependency branch May 12, 2021 12:30
forest-bot added a commit that referenced this pull request May 12, 2021
## [6.3.4](v6.3.3...v6.3.4) (2021-05-12)

### Bug Fixes

* **dependency:** ensure that project with a groupdate dependency >= 5 can install forest-rails ([#454](#454)) ([2c0a350](2c0a350))
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
## [6.3.4](ForestAdmin/forest-rails@v6.3.3...v6.3.4) (2021-05-12)

### Bug Fixes

* **dependency:** ensure that project with a groupdate dependency >= 5 can install forest-rails ([#454](ForestAdmin/forest-rails#454)) ([2c0a350](ForestAdmin/forest-rails@2c0a350))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants