Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage #390

Merged
merged 6 commits into from
Dec 9, 2020
Merged

test: add coverage #390

merged 6 commits into from
Dec 9, 2020

Conversation

GuillaumeCisco
Copy link
Contributor

@GuillaumeCisco GuillaumeCisco commented Dec 1, 2020 •
edited
Loading

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@GuillaumeCisco GuillaumeCisco changed the title chore: add coverage test: add coverage Dec 1, 2020
arnaudbesnier
arnaudbesnier suggested changes Dec 1, 2020
View reviewed changes
@arnaudbesnier arnaudbesnier removed their assignment Dec 1, 2020
@arnaudbesnier
Copy link
Contributor

Is this coverage run by the CI?

@GuillaumeCisco
Copy link
Contributor Author

Is this coverage run by the CI?

no, it is still a work in progress to show what could be done

@GuillaumeCisco
Copy link
Contributor Author

It should be ok now.
I cleaned and added codecov for travis.
Maybe we also need to bind code climate to this repository :)

@GuillaumeCisco GuillaumeCisco removed the request for review from VincentMolinie December 1, 2020 16:03
arnaudbesnier
arnaudbesnier reviewed Dec 9, 2020
View reviewed changes
arnaudbesnier
arnaudbesnier approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@arnaudbesnier arnaudbesnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎖️
Let's wait the last commit to be CI-ed to see if the coverage is still reported.

@codeclimate
Copy link

codeclimate bot commented Dec 9, 2020

Code Climate has analyzed commit 91af9e7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.4%.

View more on Code Climate.

@GuillaumeCisco GuillaumeCisco merged commit 32f8d5d into master Dec 9, 2020
@GuillaumeCisco GuillaumeCisco deleted the chore-coverage branch December 9, 2020 17:04
@forest-bot
Copy link
Member

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@forest-bot
Copy link
Member

🎉 This PR is included in version 6.0.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbesnier arnaudbesnier arnaudbesnier approved these changes

Assignees

@GuillaumeCisco GuillaumeCisco

Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeCisco @arnaudbesnier @forest-bot @VincentMolinie