Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): authenticate using oidc #383

Merged
merged 9 commits into from
Dec 9, 2020
Merged

Conversation

DrRaider
Copy link
Contributor

@DrRaider DrRaider commented Nov 26, 2020

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • No automatic tests failures
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

Need up-to-date front and back
Add 'forest-rails': '5.0.0 to /forestadmin/app/services/liana-features.js line 182

@DrRaider DrRaider self-assigned this Nov 26, 2020
@DrRaider DrRaider force-pushed the authentication/add-openid-client branch from 19eafe7 to 74d4820 Compare November 27, 2020 17:49
@DrRaider DrRaider requested a review from larcin December 1, 2020 15:07
@DrRaider DrRaider assigned larcin and unassigned DrRaider Dec 1, 2020
Copy link
Contributor

@larcin larcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

I made some comments but most are related to the "ruby" way of doing things

(plus there seems to be 5 empty files created, what are those?)

@larcin larcin assigned DrRaider and unassigned larcin Dec 2, 2020
@DrRaider DrRaider force-pushed the authentication/add-openid-client branch from f534eec to ed642e0 Compare December 3, 2020 13:55
@DrRaider DrRaider changed the base branch from master to beta December 3, 2020 13:55
@DrRaider DrRaider force-pushed the authentication/add-openid-client branch from 4a66aa5 to d67141d Compare December 3, 2020 14:49
@DrRaider DrRaider requested a review from larcin December 3, 2020 14:53
@DrRaider DrRaider assigned larcin and unassigned ghusse, DrRaider and LouisClisson Dec 3, 2020
Copy link
Contributor

@larcin larcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment and I have issues connecting to the liana

/Users/valentinl/Documents/forest/projects/forest-rails/app/services/forest_liana/authorization_getter.rb:29:in authenticate'`

@larcin larcin removed their assignment Dec 3, 2020
@DrRaider DrRaider requested a review from larcin December 7, 2020 13:44
@DrRaider DrRaider assigned larcin and unassigned DrRaider Dec 7, 2020
larcin
larcin previously approved these changes Dec 7, 2020
@larcin larcin assigned DrRaider and unassigned larcin Dec 7, 2020
ghusse
ghusse previously approved these changes Dec 8, 2020
Copy link
Contributor

@ghusse ghusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Code review

🆗

✅  Automatic tests

🆗

✅  Manual tests

I tested both on a local & production environment, everything works as expected

✅  PR title

👌

Copy link

@LouisClisson LouisClisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DrRaider DrRaider merged commit b535ab4 into beta Dec 9, 2020
@DrRaider DrRaider deleted the authentication/add-openid-client branch December 9, 2020 09:58
@DrRaider DrRaider restored the authentication/add-openid-client branch December 9, 2020 10:02
DrRaider added a commit that referenced this pull request Dec 9, 2020
forest-bot added a commit that referenced this pull request Dec 9, 2020
# [6.0.0-beta.1](v5.2.3...v6.0.0-beta.1) (2020-12-09)

### Features

* **auth:** authenticate using oidc ([#383](#383)) ([b535ab4](b535ab4))

### BREAKING CHANGES

* **auth:** New authentication system.
The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

forest-bot added a commit that referenced this pull request Feb 22, 2021
# [6.0.0](v5.4.4...v6.0.0) (2021-02-22)

### Bug Fixes

* **auth:** support multi-instances and remove auth's redirection ([#407](#407)) ([8fcf9d4](8fcf9d4))
* **gemfile:** gemfile.lock forest_liana version mismatch ([#401](#401)) ([60ceaf1](60ceaf1))

### Features

* **auth:** authenticate using oidc ([#383](#383)) ([b535ab4](b535ab4))
* **auth:** authenticate using oidc ([#400](#400)) ([4898b73](4898b73))

### BREAKING CHANGES

* **auth:** Introduces a new authentication system.
- The application_url property is required to initialize ForestLiana,
- CORS rules must be adapted (to allow null origins).
* **auth:** New authentication system.
The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
# [6.0.0-beta.1](ForestAdmin/forest-rails@v5.2.3...v6.0.0-beta.1) (2020-12-09)

### Features

* **auth:** authenticate using oidc ([#383](ForestAdmin/forest-rails#383)) ([b535ab4](ForestAdmin/forest-rails@b535ab4))

### BREAKING CHANGES

* **auth:** New authentication system.
The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
# [6.0.0](ForestAdmin/forest-rails@v5.4.4...v6.0.0) (2021-02-22)

### Bug Fixes

* **auth:** support multi-instances and remove auth's redirection ([#407](ForestAdmin/forest-rails#407)) ([8fcf9d4](ForestAdmin/forest-rails@8fcf9d4))
* **gemfile:** gemfile.lock forest_liana version mismatch ([#401](ForestAdmin/forest-rails#401)) ([60ceaf1](ForestAdmin/forest-rails@60ceaf1))

### Features

* **auth:** authenticate using oidc ([#383](ForestAdmin/forest-rails#383)) ([b535ab4](ForestAdmin/forest-rails@b535ab4))
* **auth:** authenticate using oidc ([#400](ForestAdmin/forest-rails#400)) ([4898b73](ForestAdmin/forest-rails@4898b73))

### BREAKING CHANGES

* **auth:** Introduces a new authentication system.
- The application_url property is required to initialize ForestLiana,
- CORS rules must be adapted (to allow null origins).
* **auth:** New authentication system.
The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants