-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): authenticate using oidc #383
Conversation
19eafe7
to
74d4820
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
I made some comments but most are related to the "ruby" way of doing things
(plus there seems to be 5 empty files created, what are those?)
f534eec
to
ed642e0
Compare
4a66aa5
to
d67141d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment and I have issues connecting to the liana
/Users/valentinl/Documents/forest/projects/forest-rails/app/services/forest_liana/authorization_getter.rb:29:in
authenticate'`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ ⚠️ Code review
🆗
✅ Automatic tests
🆗
✅ Manual tests
I tested both on a local & production environment, everything works as expected
✅ PR title
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
# [6.0.0-beta.1](v5.2.3...v6.0.0-beta.1) (2020-12-09) ### Features * **auth:** authenticate using oidc ([#383](#383)) ([b535ab4](b535ab4)) ### BREAKING CHANGES * **auth:** New authentication system. The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
🎉 This PR is included in version 6.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [6.0.0](v5.4.4...v6.0.0) (2021-02-22) ### Bug Fixes * **auth:** support multi-instances and remove auth's redirection ([#407](#407)) ([8fcf9d4](8fcf9d4)) * **gemfile:** gemfile.lock forest_liana version mismatch ([#401](#401)) ([60ceaf1](60ceaf1)) ### Features * **auth:** authenticate using oidc ([#383](#383)) ([b535ab4](b535ab4)) * **auth:** authenticate using oidc ([#400](#400)) ([4898b73](4898b73)) ### BREAKING CHANGES * **auth:** Introduces a new authentication system. - The application_url property is required to initialize ForestLiana, - CORS rules must be adapted (to allow null origins). * **auth:** New authentication system. The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
🎉 This PR is included in version 6.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
# [6.0.0-beta.1](ForestAdmin/forest-rails@v5.2.3...v6.0.0-beta.1) (2020-12-09) ### Features * **auth:** authenticate using oidc ([#383](ForestAdmin/forest-rails#383)) ([b535ab4](ForestAdmin/forest-rails@b535ab4)) ### BREAKING CHANGES * **auth:** New authentication system. The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
# [6.0.0](ForestAdmin/forest-rails@v5.4.4...v6.0.0) (2021-02-22) ### Bug Fixes * **auth:** support multi-instances and remove auth's redirection ([#407](ForestAdmin/forest-rails#407)) ([8fcf9d4](ForestAdmin/forest-rails@8fcf9d4)) * **gemfile:** gemfile.lock forest_liana version mismatch ([#401](ForestAdmin/forest-rails#401)) ([60ceaf1](ForestAdmin/forest-rails@60ceaf1)) ### Features * **auth:** authenticate using oidc ([#383](ForestAdmin/forest-rails#383)) ([b535ab4](ForestAdmin/forest-rails@b535ab4)) * **auth:** authenticate using oidc ([#400](ForestAdmin/forest-rails#400)) ([4898b73](ForestAdmin/forest-rails@4898b73)) ### BREAKING CHANGES * **auth:** Introduces a new authentication system. - The application_url property is required to initialize ForestLiana, - CORS rules must be adapted (to allow null origins). * **auth:** New authentication system. The application_url must be set in the ForestLiana initializer, adding a regex CORS rule for null origin is required.
Pull Request checklist:
Need up-to-date front and back
Add
'forest-rails': '5.0.0
to/forestadmin/app/services/liana-features.js
line182