[-] Filters - Support complex/generic conditions chaining #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larcin
force-pushed
the
feature/new-filter-format
branch
2 times, most recently
from
8673a41 to
f914e2d
Compare
larcin
changed the title
VincentMolinie
changed the title
VincentMolinie
requested changes
Jul 30, 2019
VincentMolinie
requested changes
Jul 31, 2019
VincentMolinie
requested changes
Aug 5, 2019
| @@ -54,20 +54,20 @@ GEM | |||
| thread_safe (~> 0.3, >= 0.3.4) | |||
There was a problem hiding this comment.
I'm not confident about all this change, may be @arnaudbesnier has an insight about that
VincentMolinie
approved these changes
Aug 6, 2019
| @@ -18,7 +18,7 @@ end | |||
|
|
|||
| group :test do | |||
| gem 'rake' | |||
| gem 'sqlite3' | |||
There was a problem hiding this comment.
Just force the value to '1.3.13', the ~> operator is hard to understand
Gemfile.lock
Outdated
| byebug (8.2.2) | ||
| concurrent-ruby (1.1.4) | ||
| crass (1.0.3) | ||
| byebug (11.0.1) |
There was a problem hiding this comment.
Ok for byebug if it still works as expected
There was a problem hiding this comment.
Not critical as it is a dev dependency
Gemfile.lock
Outdated
| thread_safe (0.3.6) | ||
| tzinfo (1.2.5) | ||
| thread_safe (~> 0.1) | ||
| useragent (0.16.5) | ||
| useragent (0.16.10) |
There was a problem hiding this comment.
Except for sqlite3, byebug, rake, rspec, (dev or test dependencies) yes rollback all the changes 🙏
larcin
force-pushed
the
feature/new-filter-format
branch
from
c08b7f9 to
d2d6c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist: