feat: support static action forms with layout #1182

realSpok · 2024-09-25T12:35:06Z

Definition of Done

#86c097c1w

General

Write an explicit title for the Pull Request, following Conventional Commits specification
Test manually the implemented changes
Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

Consider the security impact of the changes made

forest-bot · 2024-09-25T12:35:11Z

Task linked: CU-86c097c1w Story #7 - Add Ability to handle static forms with layout

EnkiP · 2024-09-27T08:49:13Z

packages/datasource-customizer/src/decorators/actions/collection.ts

          field =>
-            field.type === 'Layout' || // all forms containing some layout elements are handled as dynamic
            Object.values(field).some(value => this.isHandler(value)) ||


recursive check for layout elements

yes. I will wait for the pages to be available I think

EnkiP · 2024-09-27T08:50:27Z

packages/datasource-customizer/test/decorators/actions/collection.test.ts

  describe('with a form with layout elements', () => {
-    test('should be flagged as dynamic form', () => {
-      newBooks.addAction('make photocopy', {
-        scope: 'Single',
-        execute: (context, resultBuilder) => {
-          return resultBuilder.error('meeh');
-        },
-        form: [
-          { label: 'firstname', type: 'String' },
-          { type: 'Layout', component: 'Separator' },
-          { label: 'lastname', type: 'String' },
-        ],
-      });
-
-      expect(newBooks.schema.actions['make photocopy']).toEqual({
-        scope: 'Single',
-        generateFile: false,
-        staticForm: false,
-      });
-    });
-
    test('should compute the form recursively', async () => {


keep this test with dynamic elements in a row in a page

EnkiP

...

EnkiP

sry missclick again :/ need recursive check in getForms

codeclimate · 2024-10-07T15:25:16Z

Code Climate has analyzed commit 4b3231f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (98% is the threshold).

This pull request will bring the total coverage in the repository to 97.5% (0.0% change).

View more on Code Climate.

## [1.11.2](https://github.com/ForestAdmin/agent-nodejs/compare/example@1.11.1...example@1.11.2) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

# [1.50.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/agent@1.49.1...@forestadmin/agent@1.50.0) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-07T15:51:08Z

🎉 This PR is included in version 1.4.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-07T15:51:11Z

🎉 This PR is included in version 1.11.2 🎉

The release is available on example@1.11.2

Your semantic-release bot 📦🚀

## [1.1.35](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-dummy@1.1.34...@forestadmin/datasource-dummy@1.1.35) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-07T15:51:21Z

🎉 This PR is included in version 1.50.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.11.22](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forest-cloud@1.11.21...@forestadmin/forest-cloud@1.11.22) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

## [1.4.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-aws-s3@1.4.2...@forestadmin/plugin-aws-s3@1.4.3) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-07T15:51:27Z

🎉 This PR is included in version 1.55.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.1.6](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.5...@forestadmin/plugin-export-advanced@1.1.6) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-07T15:51:33Z

🎉 This PR is included in version 1.1.35 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.3.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-flattener@1.3.2...@forestadmin/plugin-flattener@1.3.3) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-07T15:51:39Z

🎉 This PR is included in version 1.11.22 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-07T15:51:45Z

🎉 This PR is included in version 1.4.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-07T15:51:50Z

🎉 This PR is included in version 1.1.6 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-07T15:51:54Z

🎉 This PR is included in version 1.3.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.10.3](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sequelize@1.10.2...@forestadmin/datasource-sequelize@1.10.3) (2024-10-09) ### Bug Fixes * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

## [1.14.29](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-sql@1.14.28...@forestadmin/datasource-sql@1.14.29) (2024-10-09) ### Bug Fixes * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-09T07:18:06Z

🎉 This PR is included in version 1.10.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

forest-bot · 2024-10-09T07:18:20Z

🎉 This PR is included in version 1.14.29 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.8.4](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-mongoose@1.8.3...@forestadmin/datasource-mongoose@1.8.4) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

## [1.42.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-toolkit@1.42.0...@forestadmin/datasource-toolkit@1.42.1) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

forest-bot · 2024-10-10T08:38:42Z

🎉 This PR is included in version 1.3.24 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

## [1.34.1](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/forestadmin-client@1.34.0...@forestadmin/forestadmin-client@1.34.1) (2024-10-10) ### Bug Fixes * missing exported type ([#1192](#1192)) ([7e26bd9](7e26bd9)) * **permissions:** properly check permissions when dissociating or deleting related resources ([#1190](#1190)) ([211fd1f](211fd1f)) * required fields are not required in schema when they have default values ([#1185](#1185)) ([a5501fc](a5501fc)) * search hook with layout ([#1187](#1187)) ([e75a06e](e75a06e)) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

# [1.55.0](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/datasource-customizer@1.54.1...@forestadmin/datasource-customizer@1.55.0) (2024-10-07) ### Features * support static action forms with layout ([#1182](#1182)) ([92011d8](92011d8))

feat: support static action forms with layout

910c9e9

Nicolas Moreau added 2 commits September 25, 2024 14:52

test: update tests

9633fc5

refactor: merge with main

4fbc11a

EnkiP reviewed Sep 27, 2024

View reviewed changes

EnkiP requested changes Sep 27, 2024

View reviewed changes

EnkiP approved these changes Sep 27, 2024

View reviewed changes

EnkiP requested changes Sep 27, 2024

View reviewed changes

Nicolas Moreau added 5 commits September 27, 2024 17:29

fix: nested iteration to check for dynamic fields

a26e56b

refactor: merge with main

15e567f

refactor: merge with main

ec9ef29

fix: update type

cdbdd1f

fix: agent wont start

4b3231f

EnkiP approved these changes Oct 7, 2024

View reviewed changes

realSpok merged commit 92011d8 into main Oct 7, 2024
23 checks passed

realSpok deleted the feat/support-static-action-forms-with-layout branch October 7, 2024 15:39

forest-bot added the released label Oct 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support static action forms with layout #1182

feat: support static action forms with layout #1182

realSpok commented Sep 25, 2024

forest-bot commented Sep 25, 2024

EnkiP Sep 27, 2024

realSpok Sep 27, 2024

EnkiP Sep 27, 2024

EnkiP left a comment

EnkiP left a comment

codeclimate bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 9, 2024

forest-bot commented Oct 9, 2024

forest-bot commented Oct 10, 2024

feat: support static action forms with layout #1182

feat: support static action forms with layout #1182

Conversation

realSpok commented Sep 25, 2024

Definition of Done

General

Security

forest-bot commented Sep 25, 2024

EnkiP Sep 27, 2024

Choose a reason for hiding this comment

realSpok Sep 27, 2024

Choose a reason for hiding this comment

EnkiP Sep 27, 2024

Choose a reason for hiding this comment

EnkiP left a comment

Choose a reason for hiding this comment

EnkiP left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 7, 2024

forest-bot commented Oct 9, 2024

forest-bot commented Oct 9, 2024

forest-bot commented Oct 10, 2024